Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: rewrite superset docker localhost prose #25296

Merged
merged 1 commit into from
Sep 14, 2023
Merged

docs: rewrite superset docker localhost prose #25296

merged 1 commit into from
Sep 14, 2023
+3 −3

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 14, 2023

SUMMARY

The previous prose includes some confusing content. ...

  • localhosts isn't a thing
  • this involves make one-line changes is grammatically broken

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements @jsoref!

@michael-s-molina michael-s-molina merged commit e1ddba9 into apache:master Sep 14, 2023
@jsoref jsoref deleted the docker-localhost branch September 14, 2023 12:41
This was referenced Sep 15, 2023
Closed
Closed
eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023
@jsoref @eschutho
docs: rewrite superset docker localhost prose (apache#25296)
b62ff92 
Signed-off-by: Josh Soref <[email protected]>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@jsoref
docs: rewrite superset docker localhost prose (apache#25296)
87d9a59 
Signed-off-by: Josh Soref <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@jsoref
docs: rewrite superset docker localhost prose (apache#25296)
b124fa2 
Signed-off-by: Josh Soref <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @michael-s-molina @mistercrunch